RFR(M): 8216041: [Event Request] - Deoptimization

[Markus Gronlund]

Igor, Vladimir and Erik,

Thank you for your reviews!

Markus

-----Original Message-----
From: Igor Ignatyev 
Sent: den 2 december 2019 22:19
To: Markus Gronlund <markus.gronlund at oracle.com>
Cc: hotspot-jfr-dev at openjdk.java.net; hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
Subject: Re: RFR(M): 8216041: [Event Request] - Deoptimization

Hi Markus,

looks good to me.

-- Igor

> On Dec 2, 2019, at 3:57 AM, Markus Gronlund <markus.gronlund at oracle.com> wrote:
> 
> Greetings,
> 
> Please review the following changeset to introduce a Deoptimization (uncommon trap)  event to JFR.
> 
> Igor Ignatyev has done related work under "JDK-8225554: add JFR event for uncommon trap" [1], and we have decided to merge our work, so this RFR will supersede the previous discussion related to JDK-8225554 [2].
> 
> Enhancement: https://bugs.openjdk.java.net/browse/JDK-8216041 
> Webrev: http://cr.openjdk.java.net/~mgronlun/8216041/webrev01
> Example visualization (raw JMC): http://cr.openjdk.java.net/~mgronlun/8216041/Deoptimization.jpg  
> Summary: A description of which compiler compiled the method has been added, where descriptions are keyed by values from the CompilerType enumeration. This information has also been added to the Compilation event. The current suggestion is to have stack trace information turned off by default (default.jfc), but turned on when using profile.jfc.
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8225554 
> [2] https://mail.openjdk.java.net/pipermail/hotspot-jfr-dev/2019-June/000631.html
> 
> Thank you
> Markus