RFR(XS): 8234350: assert(mode == ControlAroundStripMined && (use == sfpt || !use->is_reachable_from_root())) failed: missed a node

[Doerr, Martin]

Hi Roland,

the new asserted condition can never be true when mode == IgnoreStripMined.

So if this is intended, I suggest using 2 assertions:
1. mode != IgnoreStripMined at the beginning
2. (mode == ControlAroundStripMined && use == sfpt) ||!use->is_reachable_from_root()

Best regards,
Martin


> -----Original Message-----
> From: hotspot-compiler-dev <hotspot-compiler-dev-
> bounces at openjdk.java.net> On Behalf Of Roland Westrelin
> Sent: Sonntag, 1. Dezember 2019 15:55
> To: hotspot-compiler-dev at openjdk.java.net
> Subject: Re: RFR(XS): 8234350: assert(mode == ControlAroundStripMined &&
> (use == sfpt || !use->is_reachable_from_root())) failed: missed a node
> 
> 
> > http://cr.openjdk.java.net/~roland/8234350/webrev.00/
> 
> Anyone for a second review?
> 
> Thanks,
> Roland.