[14] RFR (XS): 8234392: C2: Extend Matcher::match_rule_supported_vector() with element type information

John Rose john.r.rose at oracle.com
Tue Dec 10 01:53:14 UTC 2019


Reviewed.

The rules for NegV[DF] and CMoveV[DF] that remain looks
puzzling to me, and would benefit from a brief comment for
future readers, explaining why they are there.

The NegV rules seem to be removable for the same reason
(size limits) that the other rules are removable.  If there’s a
tricky reason they must be called out explicitly, it would be
good to explain.  The CMoveV rules probably stem from limited
support for CMove, but again a comment would be good.

— John

On Dec 5, 2019, at 1:53 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~vlivanov/8234392/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8234392
> 
> Make basic type available in Matcher::match_rule_supported_vector() and refactor Matcher::match_rule_supported_vector() on x86.
> 
> It enables significant simplification of Matcher::match_rule_supported_vector()on x86 by using Matcher::vector_size_supported() to cover cases like AXV2 is required for 256-bit operaions on integral (see Matcher::vector_width_in_bytes() [1] for details).
> 
> Contributed-by: Jatin Bhateja <jatin.bhateja at intel.com>
> Reviewed-by: vlivanov, sviswanathan, ?
> 
> Testing: tier1-4
> 
> Best regards,
> Vladimir Ivanov
> 
> [1] http://hg.openjdk.java.net/jdk/jdk/file/tip/src/hotspot/cpu/x86/x86.ad#l1442



More information about the hotspot-compiler-dev mailing list