[aarch64-port-dev ] crash due to long offset

Pengfei Li (Arm Technology China) Pengfei.Li at arm.com
Tue Dec 10 08:28:57 UTC 2019


Hi Zhuoren,

> I also wrote a patch to solve this issue, please also review.
> http://cr.openjdk.java.net/~wzhuo/BigOffsetAarch64/webrev.00/jdk13u.pat
> ch

Thanks for your patch. I (NOT a reviewer) eyeballed your fix and found a probable mistake.

In  "enc_class aarch64_enc_str(iRegL src, memory mem) %{ ... %}", you have "if (($mem$$index == -1) && ($mem$$disp > 0)& (($mem$$disp & 0x7) != 0) && ($mem$$disp > 255))".
Should it be "&&" instead of "&" in the middle?

Another question: Is it possible to add the logic into loadStore() or another new function instead of duplicating it everywhere in aarch64.ad?

I've also CC'ed this to hotspot-compiler-dev because all hotspot compiler patches (including AArch64 specific) should go through it for review.

--
Thanks,
Pengfei



More information about the hotspot-compiler-dev mailing list