RFR(T/XS) 8215728: [Graal] we should run some Graal tests in tier1
Ekaterina Pavlova
ekaterina.pavlova at oracle.com
Tue Dec 10 20:08:38 UTC 2019
Igor,
please see new webrev here:
http://cr.openjdk.java.net/~epavlova//8215728/webrev.01/
thanks,
-katya
On 11/13/19 8:59 PM, Igor Ignatyev wrote:
> if GraalUnitTestLauncher has to be run w/ -XX:+EnableJVMCI, I guess we just have to switch back to othervm mode.
> -- Igor
>
>> On Nov 13, 2019, at 8:52 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>>
>> -XX:+EnableJVMCI is already passed to the spawn JVM by GraalUnitTestLauncher.
>> However -XX:+EnableJVMCI is also required for GraalUnitTestLauncher itself so
>> getModuleExports() function works properly for graal modules.
>> Also note that we can't pass '-XX:+EnableJVMCI' to GraalUnitTestLauncher in jtreg
>> directive as we use '@run main compiler.graalunit.common.GraalUnitTestLauncher' to launch it.
>> See also discussion regarding this issue in JDK-8216551.
>>
>> Anyway, I understand the point regarding tier1 and will see what can be done.
>>
>> thanks,
>> -katya
>>
>> On 11/13/19 1:45 PM, Igor Ignatyev wrote:
>>> all tier1 groups are expected to runnable as-is, so I think we need to update GraalUnitTestLauncher to pass -XX:+EnableJVMCI to the spawn JVM, and updated the test descriptions (and generateTests.sh) to require JVM w/ jvmci feature (@requires vm.jvmci)? then this will be a proper tier1 group.
>>> -- Igor
>>>> On Nov 13, 2019, at 1:38 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>>>>
>>>> The tests require -XX:+EnableJVMCI to be run with, so this is why I created separate group.
>>>>
>>>> On 11/13/19 1:30 PM, Igor Ignatyev wrote:
>>>>> Hi Katya,
>>>>> shouldn't this group be also into tier1_compiler group?
>>>>> -- Igor
>>>>>> On Nov 13, 2019, at 1:28 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> please review this small patch which defines jtreg test group 'tier1_compiler_graal' so we can run it
>>>>>> as part of tier1 testing. compiler/graalunit/HotspotTest.java is the most frequent failed test based on
>>>>>> bugs statistics, so I included only this group of tests for now. They also takes reasonable amount of
>>>>>> time to execute.
>>>>>>
>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8215728
>>>>>> webrev: http://cr.openjdk.java.net/~epavlova//8215728/webrev.00/index.html
>>>>>> testing: tier1
>>>>>>
>>>>>>
>>>>>> thanks,
>>>>>> -katya
>>>>
>>
>
More information about the hotspot-compiler-dev
mailing list