Re: [aarch64-port-dev ] crash due to long offset

[Wang Zhuo(Zhuoren)]

Pengfei, thanks for your comments.
Here is updated patch. 
http://cr.openjdk.java.net/~wzhuo/BigOffsetAarch64/webrev.01/


Haley, please also have a look at this patch.

Regards,
Zhuoren



------------------------------------------------------------------
From:Andrew Haley <aph at redhat.com>
Sent At:2019 Dec. 10 (Tue.) 22:06
To:Pengfei Li (Arm Technology China) <Pengfei.Li at arm.com>
Cc:hotspot compiler <hotspot-compiler-dev at openjdk.java.net>; aarch64-port-dev at openjdk.java.net <aarch64-port-dev at openjdk.java.net>
Subject:Re: [aarch64-port-dev ] crash due to long offset

On 12/10/19 8:28 AM, Pengfei Li (Arm Technology China) wrote:
> Hi Zhuoren,
> 
>> I also wrote a patch to solve this issue, please also review.
>> http://cr.openjdk.java.net/~wzhuo/BigOffsetAarch64/webrev.00/jdk13u.pat
>> ch
> Thanks for your patch. I (NOT a reviewer) eyeballed your fix and found a probable mistake.
> 
> In  "enc_class aarch64_enc_str(iRegL src, memory mem) %{ ... %}", you have "if (($mem$$index == -1) && ($mem$$disp > 0)& (($mem$$disp & 0x7) != 0) && ($mem$$disp > 255))".
> Should it be "&&" instead of "&" in the middle?
> 
> Another question: Is it possible to add the logic into loadStore() or another new function instead of duplicating it everywhere in aarch64.ad?
> 
> I've also CC'ed this to hotspot-compiler-dev because all hotspot compiler patches (including AArch64 specific) should go through it for review.

I'm looking at this.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671