RFR(S): 8235762: JVM crash in SWPointer during C2 compilation

Christian Hagedorn christian.hagedorn at oracle.com
Wed Dec 11 14:53:47 UTC 2019


Hi Felix

Thanks for working on that. Your fix also seems to work for JDK-8235700. 
I closed that one as a duplicate of yours.

>>> +              for (int i = 0; i < orig_msize; i++) {

Should be uint since orig_msize is a uint

>>> +              best_align_to_mem_ref = find_align_to_ref(memops,
>> max_idx);
>>> +              assert(best_align_to_mem_ref == NULL, "sanity");

You can merge these two lines together into 
assert(find_align_to_ref(memops, max_idx) == NULL, "sanity");
since the call belongs to the sanity check. Or just surround it by a 
#ifdef ASSERT.

>>> +  idx = max_idx;

Is max_idx always guaranteed to be valid and not -1 when accessing it later?

Best regards,
Christian


More information about the hotspot-compiler-dev mailing list