RFR(T/XS) 8235773: Tier3 fails because graalunit tests started to run with ZGC

[Ekaterina Pavlova]

done


On 12/11/19 5:21 PM, Igor Ignatev wrote:
> Perfect. Ship it.
> 
> — Igor
> 
>> On Dec 11, 2019, at 5:15 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>>
>> On 12/11/19 4:52 PM, Igor Ignatev wrote:
>>> 
>>> LGTM.
>>> One comment though, won’t it be more appropriate to add graal unit tests to tier1_compiler_not_xcomp ?
>>
>> agree, this is better, regenerated webrev
>>
>> thanks!
>>
>> -katya
>>
>>> — Igor
>>>>> On Dec 11, 2019, at 4:41 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>>>>
>>>> 
>>>> Please review the urgent fix for regression introduced by JDK-8215728.
>>>>
>>>> graalunit tests are part of hotspot_compiler_all_gcs jtreg group and started to fail there.
>>>> The tests didn't run before because they had
>>>> @requires vm.opt.final.EnableJVMCI == true
>>>>
>>>> With JDK-8215728 this check was deleted as we don't rely on extra EnableJVMCI flag anymore
>>>> but set it explicitly in graal tests.
>>>>
>>>> Not all GCs support JVMCI compiler and in particular ZGC.
>>>> The fix removes graaalunit tests from hotspot_compiler_all_gcs similar way it is done for aot_jvmci tests.
>>>> Also removed graal unit tests from hotspot_compiler_xcomp group.
>>>>
>>>> @requires vm.jvmci was added to all tests so the tests are not run on platforms which don't support JVMCI.
>>>>
>>>>
>>>>
>>>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8235773
>>>>   webrev: http://cr.openjdk.java.net/~epavlova//8235773/webrev.00/index.html
>>>> testing: tier1-3
>>>>
>>>> regards,
>>>> -katya
>>>>
>>
>