[14] RFR(S): 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99

Christian Hagedorn christian.hagedorn at oracle.com
Fri Dec 13 13:14:28 UTC 2019


Hi Roland

> Thanks for experimenting with a different solution.

No problem, I think this approach is better.

>> http://cr.openjdk.java.net/~chagedorn/8231501/webrev.01/
> 
>   173     // New traps in the MDO may have been added since we copied the
>   174     // data (concurrent deoptimizations before we acquired
>   175     // extra_data_lock above) or can be removed (a safepoint may occur
>   176     // in the prepare_metadata call above) as we translate the copy:
>   177     // update the copy as we go.
> 
> Can the above still happen?
> 
> I see you dropped the memcpy so I suppose no?

No, this cannot happen anymore since the lock is not released anymore 
after the snapshot. I updated the webrev to also remove this comment and 
the code belonging to the already removed memcpy:
http://cr.openjdk.java.net/~chagedorn/8231501/webrev.02/

Best regards,
Christian


More information about the hotspot-compiler-dev mailing list