RFR(XXS): 8230185 - assert(is_Loop()) failed: invalid node class

[Vladimir Kozlov]

Hi Jatin

Yes, this fix is correct. But you added trailing spaces to modified lines. Please, fix it.

Thanks,
Vladimir

On 12/13/19 9:22 AM, Bhateja, Jatin wrote:
> Hi All,
> 
> Please find below a link to the patch
> 
> JBS          : https://bugs.openjdk.java.net/browse/JDK-8230185
> WebRev : http://cr.openjdk.java.net/~jbhateja/8230185/webrev.00/
> 
> Here first level compilation for the method was done by C1 compiler since -Xcomp and -XX:+TieredCompilation (default) options were used, as the back-edge
> taken count went beyond threshold for Inner-Loop, OSR compilation request was issued to C2 compiler.
> 
> Ideal construction  begins from the hot loop header block and follows the control flows exposed by the ciTypeFlow model (CFG created over raw bytecodes) keeping branch probabilities into consideration. Loop detection also begins from the hot loop header and does a DFS walk till it encounters a backedge,  newly detected loop containing the mul-add graph pattern in this case is irreducible and not a natural counted loop which is a must requirement for vector VNNI pattern detection. Adding a missing check for counted loop to prevent crash here.
> 
> Kindly review.
> 
> Regards,
> Jatin
>