RFR(XXS): 8230185 - assert(is_Loop()) failed: invalid node class

[Tobias Hartmann]

Hi Jatin,

this looks good to me too but could you please add a regression test (for example, simplified
version of the JavaFuzzer generated test)?

Also, please set the bug to "In Progress".

Thanks,
Tobias

On 15.12.19 09:41, Bhateja, Jatin wrote:
> Hi Vladimir,
> 
> Updated patch is placed at following link.
> 
> http://cr.openjdk.java.net/~jbhateja/8230185/webrev.01/
> 
> Kindly also push this to the repository.
> 
> Regards,
> Jatin
> 
>> -----Original Message-----
>> From: hotspot-compiler-dev <hotspot-compiler-dev-
>> bounces at openjdk.java.net> On Behalf Of Vladimir Kozlov
>> Sent: Saturday, December 14, 2019 1:13 AM
>> To: hotspot-compiler-dev at openjdk.java.net
>> Subject: Re: RFR(XXS): 8230185 - assert(is_Loop()) failed: invalid node class
>>
>> Hi Jatin
>>
>> Yes, this fix is correct. But you added trailing spaces to modified lines. Please,
>> fix it.
>>
>> Thanks,
>> Vladimir
>>
>> On 12/13/19 9:22 AM, Bhateja, Jatin wrote:
>>> Hi All,
>>>
>>> Please find below a link to the patch
>>>
>>> JBS          : https://bugs.openjdk.java.net/browse/JDK-8230185
>>> WebRev : http://cr.openjdk.java.net/~jbhateja/8230185/webrev.00/
>>>
>>> Here first level compilation for the method was done by C1 compiler
>>> since -Xcomp and -XX:+TieredCompilation (default) options were used, as the
>> back-edge taken count went beyond threshold for Inner-Loop, OSR
>> compilation request was issued to C2 compiler.
>>>
>>> Ideal construction  begins from the hot loop header block and follows the
>> control flows exposed by the ciTypeFlow model (CFG created over raw
>> bytecodes) keeping branch probabilities into consideration. Loop detection
>> also begins from the hot loop header and does a DFS walk till it encounters a
>> backedge,  newly detected loop containing the mul-add graph pattern in this
>> case is irreducible and not a natural counted loop which is a must requirement
>> for vector VNNI pattern detection. Adding a missing check for counted loop to
>> prevent crash here.
>>>
>>> Kindly review.
>>>
>>> Regards,
>>> Jatin
>>>