RFR(S): 8235762: JVM crash in SWPointer during C2 compilation

[Tobias Hartmann]

Hi Felix,

On 12.12.19 07:24, Yangfei (Felix) wrote:
>   I have created a webrev for the patch: http://cr.openjdk.java.net/~fyang/8235762/webrev.00/  
>   Tested tier1-3 with both aarch64 and x86_64 linux release build.  
>   Newly added test case fail without the patch and pass with the patch.  

Thanks for creating a webrev and adding the test. I have some questions:
- Shouldn't we at least add an assert to verify that after SuperWord::find_adjacent_refs()
best_align_to_mem_ref != NULL if _packset.length() > 0?
- Why do you need max_idx? Isn't is the case that if find_align_to_ref returns NULL, there aren't
any comparable memory operations left and it essentially doesn't matter which one you chose? Also,
is it guaranteed that max_idx is always initialized in SuperWord::find_align_to_ref?

Thanks,
Tobias