RFR(XXS): 8230185 - assert(is_Loop()) failed: invalid node class

Tobias Hartmann tobias.hartmann at oracle.com
Tue Dec 17 07:39:42 UTC 2019


Hi Jatin,

On 16.12.19 16:42, Bhateja, Jatin wrote:
> Please find below the updated patch with the test case.
> 
> http://cr.openjdk.java.net/~jbhateja/8230185/webrev.02/

Thanks for adding the test. Some comments:
- We try to avoid bug ids in test names. I would suggest a more descriptive name like
"TestIrreducibleLoopWithVNNI".
- Please also add the test to package compiler.loopopts
- For Java code, we use 4 whitespace indentation
- The variable 'c' is not used in 'mainTest'

Thanks,
Tobias


More information about the hotspot-compiler-dev mailing list