RFR(M): 8234599: PPC64: Add support on recent CPUs and Linux for JEP-352
Gustavo Romero
gromero at linux.vnet.ibm.com
Thu Dec 19 13:43:50 UTC 2019
Hi Martin,
On 12/19/2019 07:37 AM, Doerr, Martin wrote:
> Hi Gustavo,
>
> thanks for the update. Looks good.
>
> Please remove the whitespaces between the instructions and '(' in generate_data_cache_writeback_sync() before pushing.
> Marked here by 'X':
> + __ andi_X(temp, is_presync, 1);
> + __ bneX(CCR0, SKIP);
> + __ cache_wbsync(false); // post sync => emit 'sync'
> + __ bindX(SKIP); // pre sync => emit nothing
Just for records, I uploaded v3 without the whitespaces to:
http://cr.openjdk.java.net/~gromero/8234599/v3/
instead of fixing it in place.
Should I wait any test to complete at SAP side?
Thanks a lot.
Best regards,
Gustavo
More information about the hotspot-compiler-dev
mailing list