RFR: 8236179: C1 register allocation error with T_ADDRESS

[Roman Kennke]

Hi Aditya,

> Thanks again to everyone who helped get this change in! I am happy to help backport it as well if it can wait until January.

Thank *you* for figuring this out in the first place. This seems a
rather serious bug for Shenandoah GC (and I'm still a bit surprised how
we haven't seen it yet). I just realized we're also gonna need it in
JDK14. I am not even quite sure what the process for this would be.
We'll figure it out.

Thank you!

Roman


> Thanks,
> Aditya
> 
> -----Original Message-----
> From: Roman Kennke <rkennke at redhat.com> 
> Sent: Friday, December 20, 2019 11:59 AM
> To: Doerr, Martin <martin.doerr at sap.com>; Roland Westrelin <rwestrel at redhat.com>; Aditya Mandaleeka <adityam at microsoft.com>; hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
> Cc: shenandoah-dev <shenandoah-dev at openjdk.java.net>
> Subject: Re: RFR: 8236179: C1 register allocation error with T_ADDRESS
> 
> Hi Martin,
> 
>> thanks for reviewing it. Pushed to jdk/jdk.
> 
> Thanks a lot!
> 
>> I guess we'll have to backport it after some testing time.
> 
> Yes, we're gonna need it in 11u and 8u.
> 
> Thanks and have a nice weekend (and xmas, etc, if you're also taking time off)!
> 
> Cheers,
> Roman
> 
>> Best regards,
>> Martin
>>
>>
>>> -----Original Message-----
>>> From: Roland Westrelin <rwestrel at redhat.com>
>>> Sent: Freitag, 20. Dezember 2019 16:59
>>> To: Doerr, Martin <martin.doerr at sap.com>; Aditya Mandaleeka 
>>> <adityam at microsoft.com>; hotspot compiler <hotspot-compiler- 
>>> dev at openjdk.java.net>
>>> Cc: shenandoah-dev <shenandoah-dev at openjdk.java.net>
>>> Subject: RE: RFR: 8236179: C1 register allocation error with 
>>> T_ADDRESS
>>>
>>>
>>>> http://cr.openjdk.java.net/~mdoerr/8236179_C1_T_ADDRESS/webrev.02/
>>>
>>> That looks good to me.
>>>
>>> Roland.
>>
>