RFR(XXS): clean up BarrierSet headers in c1_LIRAssembler

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Dec 20 21:36:07 UTC 2019


Hi Lx

First, when you post RFR, please, include bug id in email's Subject.

You can use jdk/submit testing to verify builds on SPARC. We are still building on it, with warning.
Changes seems fine to me but make sure verify that it builds without PCH.

Regards,
Vladimir

On 12/20/19 9:24 AM, Liu Xin wrote:
> Martin,
> 
> Thank you very much. May I know how to validate Sparc? I don't have any
> SPARC machine to access.
> 
> Thanks,
> --lx
> 
> 
> On Fri, Dec 20, 2019, 7:05 AM Doerr, Martin <martin.doerr at sap.com> wrote:
> 
>> Hi lx,
>>
>> PPC and s390 parts are ok.
>>
>> Best regards,
>> Martin
>>
>>
>>> -----Original Message-----
>>> From: hotspot-compiler-dev <hotspot-compiler-dev-
>>> bounces at openjdk.java.net> On Behalf Of Liu, Xin
>>> Sent: Freitag, 20. Dezember 2019 04:48
>>> To: 'hotspot-compiler-dev at openjdk.java.net' <hotspot-compiler-
>>> dev at openjdk.java.net>
>>> Subject: [DMARC FAILURE] RFR(XXS): clean up BarrierSet headers in
>>> c1_LIRAssembler
>>>
>>> Hi, Reviewers,
>>>
>>> Could you take a look at my webrev? I feel that those barrisetSet
>> interfaces
>>> have nothing with c1_LIRAssembler.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8236228
>>> Webrev: https://cr.openjdk.java.net/~xliu/8236228/00/webrev/
>>>
>>> I try to build on aarch64 and x86_64 and it’s fine.
>>>
>>> Thanks,
>>> --lx
>>
>>


More information about the hotspot-compiler-dev mailing list