[PATCH] Enhance jaotc to automatically find VS2017+ linker

[Igor Veresov]

Either ways would work. But GitHub is probably more straightforward.

igor



> On Jan 29, 2019, at 7:57 PM, Andrew Luo <andrewluotechnologies at outlook.com> wrote:
> 
> Thanks for the reviews.
>  
> Quick question – for future reference – what is the correct process for Graal contributions?  After seeing your email, I realized that Graal is on Github as well – and has pull requests enabled – should we be creating pull requests on Github or following the same process as other OpenJDK-related changes (mailing lists)?
>  
> Thanks,
>  
> -Andrew
>  
> From: Igor Veresov <igor.veresov at oracle.com> 
> Sent: Monday, January 28, 2019 3:14 PM
> To: Andrew Luo <andrewluotechnologies at outlook.com>
> Cc: hotspot-compiler-dev at openjdk.java.net
> Subject: Re: [PATCH] Enhance jaotc to automatically find VS2017+ linker
>  
> Alright, the code seems ok to me. I ran through our testing and there are no issues. Let’s get you a second review and then I can push your change upstream to the Graal repo.
>  
> igor
> 
> 
> 
> 
> 
> On Jan 25, 2019, at 4:53 PM, Andrew Luo <andrewluotechnologies at outlook.com <mailto:andrewluotechnologies at outlook.com>> wrote:
>  
> Hi Igor,
>  
> Yes, I’ve signed an OCA.  I’ve contributed to OpenJDK before, just not on this mailing list.
>  
> Thanks,
>  
> -Andrew
>  
> From: Igor Veresov <igor.veresov at oracle.com <mailto:igor.veresov at oracle.com>> 
> Sent: Friday, January 25, 2019 4:20 PM
> To: Andrew Luo <andrewluotechnologies at outlook.com <mailto:andrewluotechnologies at outlook.com>>
> Cc: hotspot-compiler-dev at openjdk.java.net <mailto:hotspot-compiler-dev at openjdk.java.net>
> Subject: Re: [PATCH] Enhance jaotc to automatically find VS2017+ linker
>  
> Just checking, have you signed the OCA?
>  
> igor
> 
> 
> 
> 
> 
> 
> 
> On Jan 25, 2019, at 3:56 PM, Andrew Luo <andrewluotechnologies at outlook.com <mailto:andrewluotechnologies at outlook.com>> wrote:
>  
> Minor public -> private visibility fix.  Just noticed right after I sent it out…
>  
> Thanks,
>  
> -Andrew
>  
> From: hotspot-compiler-dev <hotspot-compiler-dev-bounces at openjdk.java.net <mailto:hotspot-compiler-dev-bounces at openjdk.java.net>> On Behalf Of Andrew Luo
> Sent: Friday, January 25, 2019 3:55 PM
> To: hotspot-compiler-dev at openjdk.java.net <mailto:hotspot-compiler-dev at openjdk.java.net>
> Subject: [PATCH] Enhance jaotc to automatically find VS2017+ linker
>  
> See attached patch.  Any feedback is welcome.
>  
> Tested on a system with only VS2017 installed, just ran jaotc with a simple class file, and got the expected .dll output with no errors…
>  
> Thanks,
>  
> -Andrew
>  
> <jaotcdiff2.txt>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20190204/534cf953/attachment.html>