[13] RFR (XS): 8218406: C1: Redundant nmethod dependency for private method is added

[Vladimir Ivanov]

Thanks for the report & review, Goetz.

Best regards,
Vladimir Ivanov

On 05/02/2019 23:22, Lindenmaier, Goetz wrote:
> Hi,
> 
> I see it's been pushed, but nevertheless:
> Looks good and fixes the issue.
> 
> Thanks for fixing that fast!
> 
> Best regards,
>    Goetz
> 
>> -----Original Message-----
>> From: hotspot-compiler-dev <hotspot-compiler-dev-
>> bounces at openjdk.java.net> On Behalf Of Vladimir Ivanov
>> Sent: Dienstag, 5. Februar 2019 00:38
>> To: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
>> Subject: [13] RFR (XS): 8218406: C1: Redundant nmethod dependency for
>> private method is added
>>
>> http://cr.openjdk.java.net/~vlivanov/8218406/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8218406
>>
>> JDK-6986483 [1] enabled limited CHA support for interface methods in C1.
>> It uncovered a missing case in consequent code which add nmethod
>> dependency: neither final nor private methods can be overridden, but it
>> checks only for final ones. Thus a redundant dependency is added for
>> private interface method call and it triggers an assert during
>> dependency validation (ClassHierarchyWalker doesn't expect to see
>> private methods).
>>
>> The fix is to adjust the relevant check to avoid introducing nmethod
>> dependency for private interface methods.
>>
>> Testing: failing JCK tests, hs-precheckin-comp, tier1-5 (in progress).
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-6986483