RFR(XS) : 8145845 : [AOT] NullPointerException in compiler/whitebox/GetCodeHeapEntriesTest.java

[Vladimir Kozlov]

+1

On 2/11/19 11:59 PM, Tobias Hartmann wrote:
> Hi Igor,
> 
> looks good.
> 
> Best regards,
> Tobias
> 
> On 12.02.19 02:38, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8145845/webrev.00/index.html
>>> 5 lines changed: 0 ins; 3 del; 2 mod;
>>
>> Hi all,
>>
>> could you please review this small and trivial patch for whitebox and GetCodeHeapEntriesTest test? the test fails when run w/ AOT'ed java.base b/c WhiteBox::getCodeHeapEntries() returns null if there are no blob of the given type. the patch changes the method to return an empty array instead.
>>
>> I've also fixed the test to correctly use Optional, before it used ::get() method which might throw NoSuchElementException exception, now it uses ::orElse(null) so we will get an error from the assertion at line #81 instead.
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev//8145845/webrev.00/index.html
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8145845
>> testing: GetCodeHeapEntriesTest.java test w/ and w/o AOT'ed java.base
>>
>> Thanks,
>> -- Igor
>>