RFR 13 (S): 8196347: LogCompilation: generate log file on the fly for input to junits

[Tobias Hartmann]

Hi Eric,

this looks good to me too.

Best regards,
Tobias

On 03.01.19 00:27, Eric Caspole wrote:
> 
> On 1/2/19 17:36, Eric Caspole wrote:
>> Hi Vladimir,
>> OK I will experiment with those and let you know.
>> Thanks,
>> Eric
> 
> You are right, running with no -version produces more compilations, the log file is about 40%
> bigger. -Xbatch was sort of a wash. So I added combos of each since these are short running and will
> give more coverage.
> 
> New one:
> http://cr.openjdk.java.net/~ecaspole/JDK-8196347/02/webrev/
> 
> 
> 
>>
>>
>> On 1/2/19 17:28, Vladimir Kozlov wrote:
>>> Hi Eric,
>>>
>>> May be add -Xbatch (-XX:-BackgroundCompilation) to make sure compilation and log is complete
>>> before execution is finished. Also I think with -version much less methods are compiled than
>>> without it when 'java' help output is printed by running without arguments.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 1/2/19 2:08 PM, Eric Caspole wrote:
>>>> Hi everybody,
>>>> Could I have reviews on this change to add setup methods to produce the test +LogCompilation
>>>> files on the fly, so we can test the output of the JDK in the repo by adding it into the PATH
>>>> etc, instead of reading static files. Also, this changeset removes several large static input
>>>> files that did not have any special significance. Tested and builds with JDK 8 and 13. Nothing
>>>> prevents adding back useful static log test files later, because it is hard to reproduce some
>>>> constructs on the fly.
>>>>
>>>> Thanks,
>>>> Eric
>>>>
>>>>
>>>> JBS:
>>>> https://bugs.openjdk.java.net/browse/JDK-8196347
>>>>
>>>> webrev:
>>>> http://cr.openjdk.java.net/~ecaspole/JDK-8196347/01/webrev/