[aarch64-port-dev ] RFR(S): 8214922: Add vectorization support for fmin/fmax

Andrew Dinn adinn at redhat.com
Wed Jan 9 16:02:08 UTC 2019


Hi Pengfei,

On 09/01/2019 06:50, Pengfei Li (Arm Technology China) wrote:
> Hi Andrew,
> 
> Do you have further comments on my 2nd min/max vectorization patch?
> 
>>>> http://cr.openjdk.java.net/~pli/rfr/8214922/webrev.01/
I am ok with this version of the patch. If the use of the max/min2F
rules doesn't cause any regressions on all the architectures you tested
then it is probably ok to push it.

However, that said, I'm not clear what you mean by one comment:

"BTW: I'm also struggling to find a simple JMH case which can trigger
reduction auto-vectorization."

Do you mean that you have not been able to exercise the reduction code
at all? Or is it just that you cannot get it to work in a JMH test?

Obviously, it would be better if we would provide a JMH test that does
work. I'll see if I can provide a test.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the hotspot-compiler-dev mailing list