RFR(S):8216050:X86: Fix for Superword optimization fails with assert(0 <= i && i < _len) failed: illegal index

Tobias Hartmann tobias.hartmann at oracle.com
Fri Jan 11 12:48:32 UTC 2019


Hi Vivek,

On 11.01.19 07:58, Deshpande, Vivek R wrote:
> 1) Fix for the crash by matching the operand by swapping to right positions. 

Looks good but the change to loopopts.cpp:530 screwed up the indentation around the ifs, please fix.

> 2) Cost based generation of vpdpwssd instruction. 

Other instructions added by JDK-8214751 still miss a cost definition, for example:
http://hg.openjdk.java.net/jdk/jdk/rev/4bb6e0871bf7#l5.20

> 3) Fix generation of vector code by allowing adjacent LoadS nodes to be isomorphic when they have
> different control RangeCheck nodes 
>     for a[i] and a[i+1] accesses in same MulAddS2I node

This is unrelated to the original bug, right? If so, this should be integrated with a separate RFE.

Thanks,
Tobias


More information about the hotspot-compiler-dev mailing list