RFR(S): 8210392: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit

[Tobias Hartmann]

Hi Patric,

thanks for adding the test. This looks good to me.

Best regards,
Tobias


On 14.01.19 17:47, Patric Hedlin wrote:
> Thanks for reviewing Tobias,
> 
> On 12/18/18 1:37 PM, Tobias Hartmann wrote:
>> Hi Patric,
>>
>> were you able to reproduce this with a test (I see that one is attached to the bug)? If so, please
>> add it to the webrev. Please also remove the extra newlines (for example, in line 1146).
>>
>> The comment in line 1027 says "Use same limit as split_if_with_blocks_post". I think this is
>> outdated right?
> 
> Updated webrev with test-case.
> 
> Fixed #¤%#.
> 
> Best regards,
> Patric
> 
>> Best regards,
>> Tobias
>>
>> On 18.12.18 12:48, Patric Hedlin wrote:
>>> Dear all,
>>>
>>> I would like to ask for help to review the following change/update:
>>>
>>> Issue:  https://bugs.openjdk.java.net/browse/JDK-8210392
>>>
>>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8210392/
>>>
>>>
>>> 8210392: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed:
>>> Live Node limit exceeded limit
>>>
>>>      Avoid excessive split-if through a crude throttling approach.
>>>
>>>
>>> Testing: hs-tier1-4, hs-precheckin-comp
>>>
>>>
>>> Best regards,
>>> Patric