RFR(S): 8217042: Shenandoah: write barrier on backedge of strip mined loop causes c2 crash at expansion time

[Aleksey Shipilev]

On 1/15/19 10:03 AM, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/8217042/webrev.00/

Cannot comment on the patch itself, it looks fine to my untrained eye.

You might want to fix indents in two places before pushing, these should be inside the if-s?

Here:

2666     if (loop->_head->is_OuterStripMinedLoop()) {
2667     // Expanding a barrier here will break loop strip mining
2668     // verification. Transform the loop so the loop nest doesn't
2669     // appear as strip mined.

and here:

2680     if (loop->_head->is_OuterStripMinedLoop()) {
2681     // Expanding a barrier here will break loop strip mining
2682     // verification. Transform the loop so the loop nest doesn't
2683     // appear as strip mined.

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20190115/c5871ab6/signature-0001.asc>