RFR (M): 8216314: SIGILL in CodeHeapState::print_names()

Tobias Hartmann tobias.hartmann at oracle.com
Tue Jan 15 11:45:51 UTC 2019


Hi Lutz,

thanks for the discussions and making these changes. The fix looks good to me.

Minor style issue (no new webrev required) in codeHeapState.cpp:1289/1290/1305/1305/1306: Please add
a newline after '{' (and before '}') or at least a whitespace.

Best regards,
Tobias

On 15.01.19 12:26, Schmidt, Lutz wrote:
> Dear all,
> 
> may I please request reviews for this fix, hardening CodeHeap Analytics to not fail when used in high-load (stress) scenarios. There was quite a bit of preliminary discussion, all documented in the "Comments" section of the bug.
> 
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8216314 
> Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8216314.01/ 
> 
> Thank you!
> Lutz
>  
> 


More information about the hotspot-compiler-dev mailing list