[11u backport] RFR(S): 8215317: [GRAAL] unit test CheckGraalIntrinsics failed after 8213754

Gustavo Romero gromero at linux.vnet.ibm.com
Mon Jan 21 11:41:23 UTC 2019


On 01/21/2019 08:54 AM, Lindenmaier, Goetz wrote:
> looks good to me.

Thank for the review, Goetz!

Regards,
Gustavo
  
> Best regards,
>    Goetz.
> 
>> -----Original Message-----
>> From: Gustavo Romero <gromero at linux.vnet.ibm.com>
>> Sent: Freitag, 18. Januar 2019 15:57
>> To: hotspot-compiler-dev at openjdk.java.net; Lindenmaier, Goetz
>> <goetz.lindenmaier at sap.com>; vladimir.kozlov at oracle.com
>> Subject: [11u backport] RFR(S): 8215317: [GRAAL] unit test
>> CheckGraalIntrinsics failed after 8213754
>>
>> Hi,
>>
>> Could the following backport to 11u be reviewed, please?
>>
>> Bug     : https://bugs.openjdk.java.net/browse/JDK-8215317
>> Change  : http://hg.openjdk.java.net/jdk/jdk/rev/108a161aed93
>> Backport: http://cr.openjdk.java.net/~gromero/8215317_jdk11u/v1/
>>
>> It adds 4 intrinsics to the Graal test CheckGraalIntrinsics.java list so
>> JDK 11u becomes aware of them. Otherwise that test will break once change
>> 8213754 [0] lands 11u (which will effectively add the 4 intrinsics to
>> PPC64/Hotspot and adapt the correlated methods to be intrinsified).
>>
>> The backport changed the inclusion of the intrinsics for JDK 11 or higher,
>> instead for JDK 12 or higher (original patch).
>>
>> This backport was tested on x86_64 with
>> ./test/hotspot/jtreg/compiler/{c1,c2,intrinsics} plus
>> ./test/hotspot/jtreg/compiler/graalunit (with Graal compiler enabled)
>> and no regressions were observed too.
>>
>> Thank you.
>>
>> Best regards,
>> Gustavo
>>
>> [0] https://bugs.openjdk.java.net/browse/JDK-8213754
> 



More information about the hotspot-compiler-dev mailing list