RFR [12] 8217467 (XS): Access barriers are missing in C2 intrinsic for Base64

[Vladimir Kozlov]

Yes, changes are good. I approved it for push into JDK 12.

Thanks,
Vladimir

On 1/22/19 2:48 AM, Roman Kennke wrote:
> Looks good. Thanks!
> 
> Roman
> 
> 
>> (correct title)
>>
>> On 1/22/19 11:27 AM, Aleksey Shipilev wrote:
>>> Bug:
>>>    https://bugs.openjdk.java.net/browse/JDK-8217467
>>>
>>> Fix:
>>>    http://cr.openjdk.java.net/~shade/8217467/webrev.01/
>>>
>>> This is found and verified by Shenandoah CTW tests that verifies barrier placement. Base64 intrinsic
>>> is new, and only enabled on modern hardware (I think you need AVX512). I'd like to push this fix to
>>> jdk12.
>>>
>>> Testing: Shenandoah CTW tests, hotspot tier1 (includes compiler/intrinsics/base64), jdk-submit12
>>> (running)
>>>
>>> Thanks,
>>> -Aleksey
>>>
>>
>>
>