[11u backport] RFR(M): 8213754: PPC64: Add Intrinsics for isDigit/isLowerCase/isUpperCase/isWhitespace

[Lindenmaier, Goetz]

Done ...

Best regards,
  Goetz.

> -----Original Message-----
> From: Gustavo Romero <gromero at linux.vnet.ibm.com>
> Sent: Dienstag, 22. Januar 2019 23:54
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: Re: [11u backport] RFR(M): 8213754: PPC64: Add Intrinsics for
> isDigit/isLowerCase/isUpperCase/isWhitespace
> 
> Hi Goetz,
> 
> On 01/21/2019 09:45 AM, Gustavo Romero wrote:
> > On 01/21/2019 09:10 AM, Lindenmaier, Goetz wrote:
> >> also this change looks good.
> >
> > Thanks for reviewing it, Goetz!
> >
> > I'll ping once the approvals are ok.
> 
> This change and JDK-8215317 are approved to be pushed to 11u:
> 
> [0] https://bugs.openjdk.java.net/browse/JDK-8215317
> [1] https://bugs.openjdk.java.net/browse/JDK-8213754
> 
> Could you please push them at the same time to 11u?
> 
> Thank you!
> 
> Best regards,
> Gustavo
> 
> > Thank you.
> >
> > Regards,
> > Gustavo
> >
> >> Best regards,
> >>    Goetz.
> >>
> >>> -----Original Message-----
> >>> From: Gustavo Romero <gromero at linux.vnet.ibm.com>
> >>> Sent: Freitag, 18. Januar 2019 16:07
> >>> To: hotspot-compiler-dev at openjdk.java.net; Lindenmaier, Goetz
> >>> <goetz.lindenmaier at sap.com>; Doerr, Martin <martin.doerr at sap.com>;
> >>> vladimir.kozlov at oracle.com; Roger Riggs <Roger.Riggs at oracle.com>
> >>> Cc: Michihiro Horie <HORIE at jp.ibm.com>
> >>> Subject: [11u backport] RFR(M): 8213754: PPC64: Add Intrinsics for
> >>> isDigit/isLowerCase/isUpperCase/isWhitespace
> >>>
> >>> Hi,
> >>>
> >>> Could the following backport to 11u be reviewed, please?
> >>>
> >>> Bug     : https://bugs.openjdk.java.net/browse/JDK-8213754
> >>> Change  : http://hg.openjdk.java.net/jdk/jdk/rev/7384e00d5860
> >>> Backport: http://cr.openjdk.java.net/~gromero/8213754_jdk11u/v1/
> >>>
> >>> It adds 4 intrinsics that use instructions introduced by POWER9 in order to
> >>> speed up methods isDigit, isLowerCase, isUpperCase, and isWhitespace.
> >>>
> >>> The change is mostly PPC64-only but it does touch shared code, for
> >>> instance, in order to adapt the methods in question to be properly
> >>> intrinsified. It also needs an additional change [0], since one Graal
> >>> test has to be adapted (a separated RFR to backport [0] was sent to [1]).
> >>>
> >>> The change applies almost cleanly: only a small tweak is necessary because
> >>> the hunk for ppc.ad file relies on some absent text in the 11u code around
> >>> the change to be applied. That absent text is related to the Superword
> >>> feature (a non-related feature), which is not backported yet to 11u.
> >>>
> >>> This backport was tested on POWER8 and POWER9 and no regressions
> were
> >>> observed.
> >>>
> >>> This backport was also tested on x86_64 with
> >>> ./test/hotspot/jtreg/compiler/{c1,c2,intrinsics} plus
> >>> ./test/hotspot/jtreg/compiler/graalunit (with Graal compiler enabled) with
> >>> change 8215317 [0] applied and no regressions were observed too.
> >>>
> >>> Thank you.
> >>>
> >>> Best regards,
> >>> Gustavo
> >>>
> >>> [0] http://cr.openjdk.java.net/~gromero/8215317_jdk11u/v1/
> >>> [1] https://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2019-
> >>> January/032266.html
> >>
> >