RFR(S) [12] : 8216180 : [AOT] compiler/intrinsics/bigInteger/TestMulAdd.java crashed with AOT enabled

[Vladimir Kozlov]

I assume tests don't use -XX:AOTLibrary= flag but load them from default location in JDK. Right?
Can we instead skip such tests if any AOT library is loaded? We can check it with PrintAOT or new ouptu or new WB API.
Relying on env variable is not robust I think.

Thanks,
Vladimir

On 1/23/19 9:36 AM, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8216180/webrev.00/index.html
>> 32 lines changed: 32 ins; 0 del; 0 mod;
> 
> Hi all,
> 
> could you please review this small patch which exclude TestMulAdd test from execution if java.base is AOT'ed compiled?
> 
> the test disables some intrinsics, and if it's run w/ AOT'ed java.base there these intrinsics are enabled (which is the most common, if not the only, case) we get crash. the fix introduces new @requires value -- vm.aot.modules which contains comma-separated list of AOT'ed modules and use it to skip this test if java.base is one of them.
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8216180/webrev.00/index.html
> JBS: https://bugs.openjdk.java.net/browse/JDK-8216180
> testing: compiler/intrinsics/bigInteger tests on linux-x64 w/ JTREG=AOT_MODULES=java.base, TEST_OPTS_AOT_MODULES=java.base and w/o any extra make args
> 
> Thanks,
> -- Igor
>