[RFR] 8217359: C2 compiler triggers SIGSEGV after tranformation in ConvI2LNode::Ideal

Yangfei (Felix) felix.yang at huawei.com
Thu Jan 24 01:22:47 UTC 2019


Thanks Tobias and Vladimir.

This is pushed as : 
http://hg.openjdk.java.net/jdk/jdk/rev/44f41693631f
http://hg.openjdk.java.net/jdk/jdk12/rev/44f41693631f

Felix


> 
> Changes are good.
> 
> I approved the fix for jdk12 as HotSpot group lead.
> 
> Thanks,
> Vladimir
> 
> 
> On 1/22/19 4:03 AM, Yangfei (Felix) wrote:
> > Hi,
> >
> >      I have updated the JBS accordingly, requesting approval for integration
> into JDK 12.
> >      May I have another reviewer please?
> >
> > Thanks for your help,
> > Felix
> >
> >
> >> Hi Felix,
> >>
> >> this looks good to me, thanks for adding the test!
> >>
> >> A second review would be good. In the meantime, please request approval
> for
> >> integration into JDK 12
> >> according to:
> >> http://openjdk.java.net/jeps/3#Fix-Request-Process
> >>
> >> Thanks,
> >> Tobias
> >>
> >> On 22.01.19 02:17, Yangfei (Felix) wrote:
> >>> Hi,
> >>>
> >>>      Thanks for reviewing.  The regression test is added.
> >>>      New webrev: http://cr.openjdk.java.net/~fyang/8217359/webrev.01/
> >>>      This is committed to the submit repo:
> >> http://hg.openjdk.java.net/jdk/submit/rev/7345adfbc913
> >>>
> >>>      The email I got shows that it passed the Oralce internal tests:
> >>>      =================================================
> >>>      Build Details: 2019-01-21-1210078.felix.yang.source
> >>>      0 Failed Tests
> >>>      Mach5 Tasks Results Summary
> >>>      •	EXECUTED_WITH_FAILURE: 0
> >>>      •	NA: 0
> >>>      •	KILLED: 0
> >>>      •	UNABLE_TO_RUN: 0
> >>>      •	PASSED: 76
> >>>      •	FAILED: 0
> >>>      =================================================
> >>>
> >>>      OK to push?
> >>>
> >>> Thanks for your help,
> >>> Felix
> >>>
> >>>>
> >>>> Hi Felix,
> >>>>
> >>>> Could you please add the regression test as jtreg test?
> >>>>
> >>>> Otherwise, the fix looks reasonable to me. Nice analysis!
> >>>>
> >>>> Thanks,
> >>>> Tobias
> >>>


More information about the hotspot-compiler-dev mailing list