8217465: RFR(S): [REDO] - Optimize CodeHeap Analytics

Schmidt, Lutz lutz.schmidt at sap.com
Wed Jan 30 10:31:20 UTC 2019


Thanks for reviewing, Tobias!
Best, Lutz

On 30.01.19, 10:36, "Tobias Hartmann" <tobias.hartmann at oracle.com> wrote:

    Hi Lutz,
    
    looks good to me too.
    
    Best regards,
    Tobias
    
    On 28.01.19 14:13, Schmidt, Lutz wrote:
    > Hi all,
    > 
    > may I please request reviews for this REDO of JDK-8217250. The only relevant difference of this REDO is that I moved the 
    >   #define USE_BUFFEREDSTREAM
    > line further down. It is now located after all the #include statements. 
    > 
    > The changeset is included in our inhouse tests since Jan 23rd with no issues detected. It was submitted to jdk/submit on Jan 25th with one failure reported on windows-x64 (see attachment). I cannot relate the failure to my changes. Could someone please have a look at the logs? If the reported failure is a false positive, here are the bug and webrev links for your reviews:
    > 
    > Bug:    https://bugs.openjdk.java.net/browse/JDK-8217465
    > Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8217465.00/
    > 
    > Thanks a lot!
    > Lutz
    > 
    >  
    > 
    



More information about the hotspot-compiler-dev mailing list