RFR(S) [13] : 8217848 : [Graal] vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TestDescription.java fails
Igor Ignatyev
igor.ignatyev at oracle.com
Thu Jan 31 20:53:50 UTC 2019
Dean, Vladimir,
thanks for your review.
-- Igor
> On Jan 31, 2019, at 11:47 AM, dean.long at oracle.com wrote:
>
> Looks good.
>
> dl
>
> On 1/31/19 10:25 AM, Vladimir Kozlov wrote:
>> Yes, this is correct fix. Later if a test set MaxMetaspaceSize too small to run with Graal we will update test.
>>
>> thanks,
>> Vladimir
>>
>> On 1/30/19 9:53 PM, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev//8217848/webrev.00/index.html
>>>> 2 lines changed: 0 ins; 0 del; 2 mod;
>>>
>>> Hi all,
>>>
>>> could you please review this small fix? the test fails w/ Graal b/c it sets MaxMetaspaceSize=9m, but when we run w/ JVMCI compiler we increase default value of MetaspaceSize. the fix makes sure we don't set MetaspaceSize greater than MaxMetaspaceSize.
>>>
>>> webrev: http://cr.openjdk.java.net/~iignatyev//8217848/webrev.00/index.html
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8217848
>>> testing:
>>> - vmTestbase/nsk/jvmti/ResourceExhausted tests w/ enabled and disabled Graal
>>> - java -XX:MaxMetaspaceSize=9m -version w/ enabled and disabled Graal
>>>
>>> Thanks,
>>> -- Igor
>>>
>
More information about the hotspot-compiler-dev
mailing list