RFR: JDK-8222079: Don't use memset to initialize fields decode_env constructor in disassembler.cpp

Roman Kennke rkennke at redhat.com
Thu Jul 4 11:10:51 UTC 2019


Uh I just went through my list of open bugs only to realize that I
totally forgot to push this one. Some things changed in the meantime, so
here comes an updated patch:

http://cr.openjdk.java.net/~rkennke/JDK-8222079/webrev.02/

Can I please get another review?

Thanks,
Roman


> Looks good.
> 
> dl
> 
> On 5/3/19 9:59 AM, Roman Kennke wrote:
>> Ping?
>>
>> Thanks,
>> Roman
>>
>>
>>> Recent gcc (I use version 9) complains about using memset to
>>> initialize fields of decode_env. Let's use proper field initializers
>>> instead.
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8222079
>>> Webrev:
>>> http://cr.openjdk.java.net/~rkennke/JDK-8222079/webrev.01/
>>>
>>> Can I please get a review?
>>>
>>> Thanks, Roman
> 



More information about the hotspot-compiler-dev mailing list