[13]RFR: 8226627: assert(t->singleton()) failed: must be a constant

[B. Blaser]

Hi Jamsheed,

On Thu, 4 Jul 2019 at 20:19, Jamsheed <jamsheed.c.m at oracle.com> wrote:
>
> Hi Bernard,
>
> Thank you for the reply.
>
> On 04/07/19 9:31 PM, B. Blaser wrote:
> > Hi Jamsheed,
> >
> > Thanks for looking at this.
> > I started working on something similar some months ago (see [1]) but I
> > didn't had time to take it to completion...
>
> it looks similar. Hope i can add you as reviewer ?

Yes, your fix seems good to me too.

Thanks!
Bernard

> Best regards,
>
> Jamsheed
>
> >
> > Regards,
> > Bernard
> >
> > [1] http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2019-February/032813.html
> >
> > On Wed, 3 Jul 2019 at 15:33, Jamsheed <jamsheed.c.m at oracle.com> wrote:
> >> Hi Tobias,
> >>
> >> On 03/07/19 6:23 PM, Tobias Hartmann wrote:
> >>> Hi Jamsheed,
> >>>
> >>> On 01.07.19 07:18, Jamsheed wrote:
> >>>> webrev: http://cr.openjdk.java.net/~jcm/8226627/webrev.00/
> >>> This looks reasonable to me.
> >> Thank you for the review.
> >>> There is a typo in type.cpp:414 "infnite".
> >> corrected.
> >>
> >> updated webrev in-place.
> >>
> >> Best regards,
> >>
> >> Jamsheed
> >>
> >>> Best regards,
> >>> Tobias
> >>>
> >>>