RFR: 8227068: [Graal] MappedByteBuffer bulk access memory failures are not handled gracefully

Jamsheed jamsheed.c.m at oracle.com
Tue Jul 9 17:04:06 UTC 2019


Hi Vladimir,

i have both jvmci + graal changes  here. so i am not very clear on how 
to do it easily. upstream PR will require JVMCI changes to be there 
first right ?

Best regards,

Jamsheed

On 09/07/19 9:40 PM, Vladimir Kozlov wrote:
> Looks good. But I think you should go through upstream Graal PR first. 
> You can push into jdk/jdk simultaneously but changes should match to 
> upstream changes.
>
> thanks,
> Vladimir
>
> On 7/9/19 8:29 AM, Jamsheed wrote:
>> Hi,
>>
>> Request for review
>>
>> JDK-8191278 guarded c2 compiler Unsafe.copyMemory intrinsic for 
>> invalid memory access failures. this was not done for graal compiler 
>> intrinsic.
>>
>> this patch handles graal case.
>>
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8227068
>>
>> webrev: http://cr.openjdk.java.net/~jcm/8227068/webrev.00/
>>
>> tested: graal unittests, mach5 (1-5, tests running)
>>
>> aot failing test: manually verified.
>>
>> Best regards,
>>
>> Jamsheed
>>


More information about the hotspot-compiler-dev mailing list