RFR: 8227068: [Graal] MappedByteBuffer bulk access memory failures are not handled gracefully

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Jul 12 16:38:05 UTC 2019


Good.

I put instructions in bug report how to run failed test with AOTed java.base. Please run those tests to make sure you 
fixed the issue.

Thanks,
Vladimir

On 7/12/19 7:26 AM, Jamsheed wrote:
> Hi Vladimir,
> 
> upstream Graal PR is approved and is merged to master (links in jbs). i have applied the same patch on jdk-jdk
> 
> webrev: http://cr.openjdk.java.net/~jcm/8227068/webrev.01/
> 
> request for review.
> 
> Best regards,
> 
> Jamsheed
> 
> On 09/07/19 9:40 PM, Vladimir Kozlov wrote:
>> Looks good. But I think you should go through upstream Graal PR first. You can push into jdk/jdk simultaneously but 
>> changes should match to upstream changes.
>>
>> thanks,
>> Vladimir
>>
>> On 7/9/19 8:29 AM, Jamsheed wrote:
>>> Hi,
>>>
>>> Request for review
>>>
>>> JDK-8191278 guarded c2 compiler Unsafe.copyMemory intrinsic for invalid memory access failures. this was not done for 
>>> graal compiler intrinsic.
>>>
>>> this patch handles graal case.
>>>
>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8227068
>>>
>>> webrev: http://cr.openjdk.java.net/~jcm/8227068/webrev.00/
>>>
>>> tested: graal unittests, mach5 (1-5, tests running)
>>>
>>> aot failing test: manually verified.
>>>
>>> Best regards,
>>>
>>> Jamsheed
>>>


More information about the hotspot-compiler-dev mailing list