RFR(XS) 8227632: Incorrect PrintCompilation message: made not compilable on levels 0 1 2 3 4

[Boris Ulasevich]

Hi,

 > I agree that printing all levels values when particular
 > one is passed is wrong.

I would say it have certain sense for C1: with directive "c1: 
{Exclude:true}" the output for 
print_made_not_compilable(comp_level=CompLevel_full_profile) is "made 
not compilable on levels 0 1 2 3" - it is weird to mention zero 
(interpreter) level in this context, but 1 2 3 is Ok for me. Anyway, I 
like the output to be simple and clear. Here is the updated webrev:

-      tty->print("levels ");
-      for (int i = (int)CompLevel_none; i <= comp_level; i++) {
-        tty->print("%d ", i);
-      }
+      tty->print("level %d ", comp_level);

http://cr.openjdk.java.net/~bulasevich/8227632/webrev.01

thanks,
Boris

P.S. jtreg/compiler/compilercontrol: OK

On 12.07.2019 20:02, Vladimir Kozlov wrote:
> Hi, Boris
> 
> I agree that printing all levels values when particular one is passed is 
> wrong.
> 
> I think you should simply print comp_level value because it should be 
> specific in all cases (leaving CompLevel_all check as it is and may be 
> adding missing AOT check).
> 
> thanks,
> Vladimir
> 
> On 7/12/19 5:33 AM, Boris Ulasevich wrote:
>> Hi,
>>
>> Can I please have a review for the simple logging issue. Current 
>> PrintCompilation message looks confusing, it reports "levels 0 1 2 3 
>> 4" when level 4 only was disabled.
>> Example:
>> $ echo [{ match: [\"*.*\"], c2: {Exclude:true} }] > cdf.txt
>> $ java -XX:+PrintCompilation -XX:+UnlockDiagnosticVMOptions 
>> -XX:CompilerDirectivesFile=cdf.txt HelloWorld
>> ### Excluding compile: java.io.OutputStreamWriter::write
>> made not compilable on levels 0 1 2 3 4 
>> java.io.OutputStreamWriter::write (11 bytes) excluded by CompileCommand
>> ### Excluding compile: java.lang.String::equals
>> made not compilable on level 0 1 2 3 4 java.lang.String::equals (50 
>> bytes)   excluded by CompileCommand
>>
>> http://bugs.openjdk.java.net/browse/JDK-8227632
>> http://cr.openjdk.java.net/~avoitylov/8227632/webrev.00
>>
>> thanks,
>> Boris