[14]RFR: 8227439: Turn off AOT by default

Igor Ignatyev igor.ignatyev at oracle.com
Fri Jul 19 16:32:39 UTC 2019


Hi Rahul,

thanks for taking care of this and all the tests, appreciate that. As UseAOT used to be true by default, you should add to all places where AOTLibrary is used, e.g. in make/RunTests.gmk, and as it seems like an easy error (for our users) to make, I think we need to check that AOTLibrary has value only if UseAOT is true and generate an error at initialization time if it's not a case. this will help us and all the users to spot places where AOT was expected to kick in.

(I have not looked at all the changed files yet)

Thanks,
-- Igor 

> On Jul 19, 2019, at 12:52 AM, Rahul Raghavan <rahul.v.raghavan at oracle.com> wrote:
> 
> Hi,
> 
> Please review the following fix changeset and
> related release-note task (8228418).
> 
> 
> <webrev> - http://cr.openjdk.java.net/~rraghavan/8227439/webrev.01/
> 
> 
> # https://bugs.openjdk.java.net/browse/JDK-8227439
> (Turn off AOT by default)
> 
> # CSR - https://bugs.openjdk.java.net/browse/JDK-8227833
> 
> # RN - https://bugs.openjdk.java.net/browse/JDK-8228418
> 
> 
> -- AOT support related flags `UseAOT`, `PrintAOT` and `AOTLibrary` are made experimental;
> and `UseAOT` flag is turned off by default.
> Also added required -XX:+UnlockExperimentalVMOptions, related changes in tests.
> 
> -- Got approval for related CSR - 8227833
> and created Release-Note task as commented - 8228418.
> 
> -- tried tests --job hs-tier4,hs-tier4-graal,hs-tier6,hs-tier6-graal.
> Could not find any issues due to proposed changes.
> 
> 
> Please let me know if missed any changes or testing.
> 
> 
> Thanks,
> Rahul



More information about the hotspot-compiler-dev mailing list