RFR: 8227407: ZGC: C2 loads and load barriers can get separated by safepoints

Erik Ă–sterlund erik.osterlund at oracle.com
Mon Jul 22 16:51:46 UTC 2019


Hi Roland,

How about UnknownControl? "Dependency" is kind of implied by the enum type.

Webrev:
http://cr.openjdk.java.net/~eosterlund/8227407/webrev.03/

Incremental:
http://cr.openjdk.java.net/~eosterlund/8227407/webrev.02_03/

What do you think?

Thanks,
/Erik

On 2019-07-22 16:57, Roland Westrelin wrote:
> 
>> How would you feel about adding a new enum value for UnsafePinned, and
>> modifying the LoadNode::Ideal transformation to
>> explicitly allow the floating if the !depends_only_on_test() ||
>> is_unsafe_pinned()?
> 
> That's fine with me but the name UnsafePinned wouldn't work because
> Pinned is currently used for one thing other than unsafe: some arraycopy
> related optimizations. UnknownControlDependency or something shorter?
> 
> Roland.
> 


More information about the hotspot-compiler-dev mailing list