RFR (S) 8228674: LogCompilation: Improvements to log compare feature

[Tobias Hartmann]

Hi Eric,

looks good to me.

Best regards,
Tobias

On 29.07.19 19:31, Eric Caspole wrote:
> Good catch.
> 
> http://cr.openjdk.java.net/~ecaspole/JDK-8228674/02/
> 
> Also, in this one I remembered to update the copyrights.
> Eric
> 
> 
> On 7/26/19 21:46, Vladimir Kozlov wrote:
>> It seems 'compiler' field in Compilation class (Compilation.java) is not used any more.
>>
>> Otherwise looks good.
>>
>> Thanks,
>> Vladimir
>>
>> I set fix version in RFE to JDK 14. It is too late for jdk 13.
>>
>> On 7/26/19 12:01 PM, Eric Caspole wrote:
>>> Hi everybody, could I have reviews on this enhancement/fix to LogCompilation so the log compare
>>> will work better and show more information about the methods being compared:
>>>
>>> JBS:
>>> https://bugs.openjdk.java.net/browse/JDK-8228674
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~ecaspole/JDK-8228674/01/webrev/
>>>
>>> Thanks,
>>> Eric