[14] RFR(S): 6394013: C2: Remove VerifyOpto

[Vladimir Kozlov]

> On Jul 31, 2019, at 12:27 AM, Christian Hagedorn <christian.hagedorn at oracle.com> wrote:
> 
> Hi Vladimir
> 
> Thanks for taking a look at it and pointing that out. I just thought this line was there due to the VerifyOpto flag. But in that case I rather undo the change and keep the code there as before and change the comment. I updated the webrev:
> http://cr.openjdk.java.net/~thartmann/6394013/webrev.01/

Good.

> 
> Should I file a new RFE for investigating the effect of removing that line?

Yes please. 

Thanks
Vladimir 

> 
> Best regards,
> Christian
> 
> 
>> On 29.07.19 18:39, Vladimir Kozlov wrote:
>> Hi Christian
>> I am not sure about removing code in loopopts.cpp. Yes, comment have to be adjusted but we need investigate more how removing this code can affect optimization.
>> The issue here is not false-positive report from VerifyOpto but that optimization could be undone.
>> We do run _igvn.optimize() at the end of each loop opts iteration.
>> Thanks,
>> Vladimir
>>> On 7/29/19 6:18 AM, Christian Hagedorn wrote:
>>> Hi
>>> 
>>> Please review the following enhancement:
>>> https://bugs.openjdk.java.net/browse/JDK-6394013
>>> http://cr.openjdk.java.net/~thartmann/6394013/webrev.00/
>>> 
>>> This kills the VerifyOpto flag.
>>> 
>>> Thanks!
>>> 
>>> Best regards,
>>> Christian