RFR: 8224162: assert(profile.count() == 0) failed: sanity in InlineTree::is_not_reached

[Vladimir Ivanov]

FYI there was a new failure in compiler/unsafe/UnsafeGetConstantField 
spotted on solaris-sparcv9.  I'm looking into it and let you know about 
my findings.

Best regards,
Vladimir Ivanov

On 01/06/2019 04:37, Jie Fu wrote:
> Hi Vladimir Ivanov,
> 
> Thanks for your review and suggestions.
> Updated: http://cr.openjdk.java.net/~jiefu/8224162/webrev.10/
> 
> Thanks a lot.
> Best regards,
> Jie
> 
> On 2019/6/1 上午5:47, Vladimir Ivanov wrote:
>> +template <typename L, typename R>
>> +int ciMethod::saturated_add(L a, R b) {
>>
>> What do you think about moving it to globalDefinitions.hpp?
>>
>> Probably, it's worth getting rid of the template parameters and 
>> introduce specializations (akin to JAVA_INTEGER_OP) since the 
>> implementation makes sense only for int/uint.
> It seems cool. I like this style.
>>
>> +  jlong sum  = src1 + src2;
>> I'd prefer to see explicit casts to jlong to stress there's no 
>> overflow possible here for 32-bit values.
>>
> Done
>>
>> +    return c < 0 ? max_jint : c;
>> +      case Bytecodes::_instanceof: return c > 0 ? min_jint : c;
>>
>> Please, put parentheses around ternary expressions.
>>
> Done
> 
>