[13] RFR (S): 8225106: C2: Parse::clinit_deopt asserts when holder klass is in error state

[Vladimir Ivanov]

Thanks, Vladimir.

Best regards,
Vladimir Ivanov

On 05/06/2019 22:36, Vladimir Kozlov wrote:
> Looks good.
> 
> Thanks,
> Vladimir K.
> 
> On 6/5/19 11:47 AM, Vladimir Ivanov wrote:
>> Thanks, Martin.
>>
>> Updated webrev:
>>    http://cr.openjdk.java.net/~vlivanov/8225106/webrev.01/
>>
>> One more review, please?
>>
>>>>> Thanks for improving the test. Seems like you currently expect a wrong
>>>> exception:
>>>>> Execution failed: `main' threw exception: java.lang.AssertionError:
>>>> INIT_FAILURE: unexpected exception thrown: expected
>>>> java.lang.NoClassDefFoundError, caught java.lang.AssertionError
>>>>
>>>> More like the error message is a bit misleading: the failure is caused
>>>> by a  bug which is addressed by JDK-8225141 [1]. Would providing
>>>> exception message improve the situation?
>>>
>>> Thanks for explaining. I'd appreciate a message improvement, but I 
>>> don't insist on it.
>>
>> Now it prints [1]: unexpected exception thrown: expected 
>> java.lang.NoClassDefFoundError, caught java.lang.AssertionError: 
>> INIT_FAILURE: no exception thrown
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> [1]
>> ----------System.err:(23/1765)----------
>> java.lang.AssertionError: INIT_FAILURE: unexpected exception thrown: 
>> expected java.lang.NoClassDefFoundError, caught 
>> java.lang.AssertionError: INIT_FAILURE: no exception thrown
>>    at ClassInitBarrier.failure(ClassInitBarrier.java:174)
>>    at ClassInitBarrier.execute(ClassInitBarrier.java:161)
>>    at 
>> ClassInitBarrier.lambda$checkBlockingAction$5(ClassInitBarrier.java:326)
>>    at ClassInitBarrier.checkBlockingAction(ClassInitBarrier.java:328)
>>    at ClassInitBarrier$Test.runTests(ClassInitBarrier.java:110)
>>    at ClassInitBarrier$Test.run(ClassInitBarrier.java:144)
>>    at ClassInitBarrier.main(ClassInitBarrier.java:444)
>>    at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
>> Method)
>>    at 
>> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
>>
>>    at 
>> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 
>>
>>    at java.base/java.lang.reflect.Method.invoke(Method.java:567)
>>    at 
>> com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) 
>>
>>    at java.base/java.lang.Thread.run(Thread.java:830)
>> Caused by: java.lang.AssertionError: INIT_FAILURE: no exception thrown
>>    at ClassInitBarrier.failure(ClassInitBarrier.java:170)
>>    at ClassInitBarrier.execute(ClassInitBarrier.java:153)
>>    ... 11 more
>>
>>