[13] RFR(S) 8225350: compiler/jvmci/compilerToVM/IsCompilableTest.java timed out

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Jun 6 18:33:32 UTC 2019


Good suggestion. I will do that.

Thanks
Vladimir

> On Jun 6, 2019, at 11:23 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> Hi Vladimir,
> 
> am I right assuming that +TieredCompilation is required only till we get libgraal? if so, I'd prefer to have them as separate @require directives (jtreg join all @require by logical-and) and preceded by @comment saying they are they needed and when they can be remove, smth like this:
> 
>> diff -r f5dfbaa152ef test/hotspot/jtreg/compiler/jvmci/TestJVMCIPrintProperties.java
>> --- a/test/hotspot/jtreg/compiler/jvmci/TestJVMCIPrintProperties.java   Wed Jun 05 18:28:03 2019 -0700
>> +++ b/test/hotspot/jtreg/compiler/jvmci/TestJVMCIPrintProperties.java   Thu Jun 06 11:21:51 2019 -0700
>> @@ -25,7 +25,9 @@
>>  * @test TestBasicLogOutput
>>  * @bug 8203370
>>  * @summary Ensure -XX:-JVMCIPrintProperties can be enabled and successfully prints expected output to stdout.
>> - * @requires vm.jvmci
>> + * @requires vm.jvmci && vm.compMode == "Xmixed"
>> + * @comment graal w/ -Tiered is too slow, excluding this combination till we get libgraal (JDK-8207267), 
>> + * @requires !vm.graal.enabled | vm.opt.TieredCompilation == null | vm.opt.TieredCompilation == true
>>  * @library /test/lib
>>  */
> 
> -- Igor
> 
>> On Jun 5, 2019, at 3:20 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8225350
>> http://cr.openjdk.java.net/~kvn/8225350/webrev.00/
>> 
>> Tests which use JVMCICompiler (Graal) explicitly are timed out when run with -Xcomp -XX:-TieredCompilation flags.
>> 
>> Run such tests only in Xmixed  + TieredCompilation mode.
>> 
>> Thanks,
>> Vladimir
> 



More information about the hotspot-compiler-dev mailing list