RFR(S): 8225388: Running jcmd Compiler.CodeHeap_Analytics all 0 cause crash.

Tobias Hartmann tobias.hartmann at oracle.com
Fri Jun 7 08:07:24 UTC 2019


Hi Leonid,

this looks good to me! Please remove the extra whitespace at the end of compileBroker.hpp:420 before
the ")". No new webrev required.

Thanks,
Tobias

On 07.06.19 02:36, Leonid Mesnik wrote:
> Hi
> 
> Could you please review following fix which verify parameter for Compiler.CodeHeap_Analytics
> command. So jcmd just exits instead of crashing target VM. Regression test was added, hs-tier1/2
> passed.
> 
> webrev: http://cr.openjdk.java.net/~lmesnik/8225388/webrev.00/
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8225388
> 
> Leonid
> 
> 


More information about the hotspot-compiler-dev mailing list