[13] RFR(S) 8225350: compiler/jvmci/compilerToVM/IsCompilableTest.java timed out

[Igor Ignatyev]

LGTM

-- Igor

> On Jun 7, 2019, at 12:35 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~kvn/8225350/webrev.02/
> 
> After few testing I found that no need check Tiered compilation to pass tests.
> Some changed tests (like IsCompilableTest.java) don't need Graal to compile a method - they only use JVMCI API.
> Timeout happened with them only because of -Xcomp stop execution until a method is compiled (Xcomp switch off background compilation). Require running in Xmixed more is enough to avoid timeout even when TieredCompilation is off.
> 
> I kept TieredCompilation check in MaterializeVirtualObjectTest.java which needs it for execution.
> 
> TestJVMCIPrintProperties.java does not need Graal. It forks process with -Djvmci.Compiler=null to check properties setting and exit after that. So I excluding it from runs with Graal.
> 
> Thanks,
> Vladimir
> 
> On 6/6/19 11:33 AM, Vladimir Kozlov wrote:
>> Good suggestion. I will do that.
>> Thanks
>> Vladimir
>>> On Jun 6, 2019, at 11:23 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>>> 
>>> Hi Vladimir,
>>> 
>>> am I right assuming that +TieredCompilation is required only till we get libgraal? if so, I'd prefer to have them as separate @require directives (jtreg join all @require by logical-and) and preceded by @comment saying they are they needed and when they can be remove, smth like this:
>>> 
>>>> diff -r f5dfbaa152ef test/hotspot/jtreg/compiler/jvmci/TestJVMCIPrintProperties.java
>>>> --- a/test/hotspot/jtreg/compiler/jvmci/TestJVMCIPrintProperties.java   Wed Jun 05 18:28:03 2019 -0700
>>>> +++ b/test/hotspot/jtreg/compiler/jvmci/TestJVMCIPrintProperties.java   Thu Jun 06 11:21:51 2019 -0700
>>>> @@ -25,7 +25,9 @@
>>>>  * @test TestBasicLogOutput
>>>>  * @bug 8203370
>>>>  * @summary Ensure -XX:-JVMCIPrintProperties can be enabled and successfully prints expected output to stdout.
>>>> - * @requires vm.jvmci
>>>> + * @requires vm.jvmci && vm.compMode == "Xmixed"
>>>> + * @comment graal w/ -Tiered is too slow, excluding this combination till we get libgraal (JDK-8207267),
>>>> + * @requires !vm.graal.enabled | vm.opt.TieredCompilation == null | vm.opt.TieredCompilation == true
>>>>  * @library /test/lib
>>>>  */
>>> 
>>> -- Igor
>>> 
>>>> On Jun 5, 2019, at 3:20 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8225350
>>>> http://cr.openjdk.java.net/~kvn/8225350/webrev.00/
>>>> 
>>>> Tests which use JVMCICompiler (Graal) explicitly are timed out when run with -Xcomp -XX:-TieredCompilation flags.
>>>> 
>>>> Run such tests only in Xmixed  + TieredCompilation mode.
>>>> 
>>>> Thanks,
>>>> Vladimir
>>>