RFR (XS) 8224234: compiler/codegen/TestCharVect2.java fails in test_mulc

Deshpande, Vivek R vivek.r.deshpande at intel.com
Fri Jun 7 22:48:14 UTC 2019


Thank you All.
Pushed the changes.

Regards,
Vivek

-----Original Message-----
From: Viswanathan, Sandhya 
Sent: Friday, June 7, 2019 11:45 AM
To: Vladimir Ivanov <vladimir.x.ivanov at oracle.com>; Tobias Hartmann <tobias.hartmann at oracle.com>
Cc: hotspot-compiler-dev at openjdk.java.net; Deshpande, Vivek R <vivek.r.deshpande at intel.com>
Subject: RE: RFR (XS) 8224234: compiler/codegen/TestCharVect2.java fails in test_mulc

Hi Vladimir/Tobias,

Thanks a lot for the review.

Best Regards,
Sandhya

-----Original Message-----
From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com]
Sent: Friday, June 07, 2019 3:41 AM
To: Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR (XS) 8224234: compiler/codegen/TestCharVect2.java fails in test_mulc

Looks good.

Best regards,
Vladimir Ivanov

On 07/06/2019 03:41, Viswanathan, Sandhya wrote:
> Please find below a small patch which fixes the issue:
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8224234
> 
> Patch: http://cr.openjdk.java.net/~sviswanathan/8224234/
> 
> Multiplication is implemented as shift, add sequence in certain cases.
> 
> The problem was occurring because the "shift by" register was being 
> overwritten due to missing effect statement in the shift rules.
> 
> The problem was introduced as part of 
> https://bugs.openjdk.java.net/browse/JDK-8222074.
> 
> The patch adds the missing effect statements.
> 
> Best Regards,
> 
> Sandhya
> 


More information about the hotspot-compiler-dev mailing list