RFR(S): 8225388: Running jcmd Compiler.CodeHeap_Analytics all 0 cause crash.

[Schmidt, Lutz]

Hi Leonid, 
thanks for taking care of this. I’m on vacation  and almost offline.
Best, Lutz

Lutz Schmidt | P&I Technology HCP Core | +49 (6227) 7-42834

On 7. Jun 2019, at 23:14, Leonid Mesnik <leonid.mesnik at oracle.com> wrote:

Thank you for review.

Leonid

> On Jun 7, 2019, at 1:07 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:
> 
> Hi Leonid,
> 
> this looks good to me! Please remove the extra whitespace at the end of compileBroker.hpp:420 before
> the ")". No new webrev required.
> 
> Thanks,
> Tobias
> 
>> On 07.06.19 02:36, Leonid Mesnik wrote:
>> Hi
>> 
>> Could you please review following fix which verify parameter for Compiler.CodeHeap_Analytics
>> command. So jcmd just exits instead of crashing target VM. Regression test was added, hs-tier1/2
>> passed.
>> 
>> webrev: http://cr.openjdk.java.net/~lmesnik/8225388/webrev.00/
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8225388
>> 
>> Leonid
>> 
>>