[13] RFR: 8226198: use of & instead of && in LibraryCallKit::arraycopy_restore_alloc_state

[Rahul Raghavan]

 >> Please also fix the indentation in line 4505
Done, pushed.

Thanks Tobias, Vladimir.

-Rahul

On 17/06/19 8:51 PM, Vladimir Kozlov wrote:
> +1
> 
> Thanks,
> Vladimir
> 
> On 6/17/19 7:57 AM, Tobias Hartmann wrote:
>> Hi Rahul,
>>
>> looks good and trivial. Please also fix the indentation in line 4505 
>> before pushing.
>>
>> Best regards,
>> Tobias
>>
>> On 17.06.19 16:53, Rahul Raghavan wrote:
>>> Hi,
>>>
>>> Please review the following proposed changes for JDK 13.
>>>
>>> <webrev> - http://cr.openjdk.java.net/~rraghavan/8226198/webrev.00/
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8226198
>>> (correctly used logical operator)
>>>
>>> [src/hotspot/share/opto/library_call.cpp]
>>>   JVMState* 
>>> LibraryCallKit::arraycopy_restore_alloc_state(AllocateArrayNode* 
>>> alloc, int&
>>> saved_reexecute_sp) {
>>> ................
>>> -    if (!C->too_many_traps(trap_method, trap_bci, 
>>> Deoptimization::Reason_intrinsic) &
>>> +    if (!C->too_many_traps(trap_method, trap_bci, 
>>> Deoptimization::Reason_intrinsic) &&
>>>             !C->too_many_traps(trap_method, trap_bci, 
>>> Deoptimization::Reason_null_check)) {
>>>         // Make sure there's no store between the allocation and the
>>>         // arraycopy otherwise visible side effects could be rexecuted
>>>         // in case of deoptimization and cause incorrect execution.
>>> ................
>>>
>>>
>>> Confirmed no issues with testing.
>>>
>>> Thanks,
>>> Rahul