JMH Tests Support for JDK-8222074

[Rukmannagari, Shravya]

Hi Vladimir,
Thank you for reviewing the patch. I have updated the patch as per your comments. Please let me know if you have any questions or comments.
http://cr.openjdk.java.net/~srukmannagar/JMHTests/webrev.02/

Thanks,
Shravya.

-----Original Message-----
From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com] 
Sent: Tuesday, June 18, 2019 7:24 AM
To: Rukmannagari, Shravya <shravya.rukmannagari at intel.com>; hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
Subject: Re: JMH Tests Support for JDK-8222074


> Webrev: http://cr.openjdk.java.net/~srukmannagar/JMHTests/webrev/

Some comments:

   35     private static final int COUNT = 1024;

I'd prefer to see a parameter (@Param) instead of hard-coded value and different input sizes to be tested (e.g., fits into L1/L2/L3, memory-bound case).


   50     private Random r = new Random();

In general, it's a good practice (for diagnostic purposes) to either fix the seed or allow to specify it from command line. For example, you could introduce additional parameter (@Param seed) and randomize it when "seed == 0". In that case, it should be printed into the log, so it's possible to rerun the benchmark with the same seed.

Otherwise, looks good!

Best regards,
Vladimir Ivanov